8000 speculative fix for failed spatial updates in scenecomposer window by neph1 · Pull Request #624 · jMonkeyEngine/sdk · GitHub
[go: up one dir, main page]
Skip to content

speculative fix for failed spatial updates in scenecomposer window #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 15, 2024
Merged

speculative fix for failed spatial updates in scenecomposer window #624

merged 2 commits into from
Dec 15, 2024

Conversation

neph1
Copy link
Contributor
@neph1 neph1 commented Nov 26, 2024

Since there's a big:

//TODO: refresh does not work

and I seem to remember seeing it when doing the ExternalChangeScanner changes, I refactored the methods there to do the same thing in this case.
I haven't actually verified that it works in this instance, yet.

@tonihele
Copy link
Contributor

Nice, we are going get a good fix release soon

capdevon
capdevon suggested changes Nov 26, 2024
View reviewed changes
@capdevon
Copy link
Contributor
capdevon commented Nov 26, 2024 •
edited
Loading

Thanks for looking into this issue @neph1. I'm curious, does this fix also address the issue of the 'AnimComposer' node and its child animations not updating?

@neph1
Copy link
Contributor Author
neph1 commented Nov 26, 2024

Thanks for looking into this issue @neph1. I'm curious, does this fix also address the issue of the 'AnimComposer' node and its child animations not updating?

I would think so, but I haven't tested. The original use case worked and I remember specifically adding support in ExternalChangeScanner for the new animation system.

@neph1 neph1 merged commit 3edabe7 into jMonkeyEngine:master Dec 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@capdevon capdevon capdevon requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neph1 @tonihele @capdevon
0