8000 Update AbstractObjectNormalizer::SKIP_UNINITIALIZED_VALUES description by ivannemets-sravniru · Pull Request #1 · ivannemets-sravniru/symfony-docs · GitHub
[go: up one dir, main page]

Skip to content

Update AbstractObjectNormalizer::SKIP_UNINITIALIZED_VALUES description #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ivannemets-sravniru
Copy link
Owner

Hi! @vuryss

I've created a PR symfony/symfony#43469 that slightly changes usage of SKIP_UNINITIALIZED_VALUES context option you implemented in Symfony 5.4.

As my PR has already been approved by one reviewer, I hope it will be eventually merged and added to upcomming 5.4 release. So, I think your docs PR symfony#15823 should be updated to reflect my changes.

I suggest waiting until symfony/symfony#43469 is merged and then, if it looks good, add my changes to your docs PR.

Cheers!

@ivannemets-sravniru ivannemets-sravniru changed the title Update serializer.rst Update AbstractObjectNormalizer::SKIP_UNINITIALIZED_VALUES description Oct 14, 2021
@vuryss
Copy link
vuryss commented Oct 14, 2021

Hey, @ivannemets-sravniru, thanks for notifying me. Once it's merged I will try to update the docs. If I don't notice in time - ping me again :)

@ivannemets-sravniru
Copy link
Owner Author

Hey @vuryss! Just wanted to let you know - my PR has been merged into 5.4 branch, so I think it does make sense to merge changes I made to SKIP_UNINITIALIZED_VALUES option documentation into your branch to update your original doc PR. Please have a look when you get a chance.
Thanks!

@vuryss
Copy link
vuryss commented Oct 18, 2021

Hey @vuryss! Just wanted to let you know - my PR has been merged into 5.4 branch, so I think it does make sense to merge changes I made to SKIP_UNINITIALIZED_VALUES option documentation into your branch to update your original doc PR. Please have a look when you get a chance. Thanks!

Done, your changes are included into the Docs PR: symfony#15823

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0