Fix rename issues in dashboard #8000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
- Do not display the full path of the selected item in the text box (warning : this removes the possibility of moving a file/folder using the rename dialog. Maybe someone finds this helpful)
- Adapt dialog for files and notebook.
- Do not allow renaming a running notebook (currently, renaming a running notebook would result in duplication instead of renaming after the open notebook saves/autosaves using the old name)
- Do not display the full path of the selected item in the text box - Adapt dialog for files and notebook - Do not allow renaming a running notebook
Member
|
@Carreau you marked this as 4.0. It seems like a fix appropriate for 3.1, no? |
Member
|
Hum, Maybe. Seem we tagged the same day, and my action say modified 4.0,3.1, So I guess I tagged 4.0 by mistake, then switched to 3.1 but was not taken into account.... Seem sensible for 3.x, and code is straitforward. |
Member
|
(rechanging to 3.1) |
minrk
added a commit
that referenced
this pull request
Mar 25, 2015
- Do not display the full path of the selected item in the text box (**warning** : this removes the possibility of moving a file/folder using the rename dialog. Maybe someone finds this helpful) - Adapt dialog for files and notebook. - Do not allow renaming a running notebook (currently, renaming a running notebook would result in duplication instead of renaming after the open notebook saves/autosaves using the old name)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.