Reorganize the python/server side of the notebook #3321
Conversation
I have also created a top-level utils.py for notebook related stuff
| import stat | ||
| import threading | ||
|
|
||
| import logging |
|
Just to summarize the design discussion from chat:
|
| self.finish() | ||
|
|
||
|
|
||
| class ZMQStreamHandler(websocket.WebSocketHandler): |
There was a problem hiding this comment.
Do these ZMQStreamHandlers belong in the base dir, rather than kernel? They aren't really specific.
| ModifyNotebookCheckpointsHandler | ||
| ), | ||
|
|
||
| # Load the (URL pattern, handler) tuples for each component. |
There was a problem hiding this comment.
did you want to put this block in an init_handlers method, to facilitate subclassing? If so, probably init_settings for the block below as well.
There was a problem hiding this comment.
Yes, I will do that now.
|
Looks like you need to update some test exclusions |
|
After catching up the test exclusions, 👍 to merge. |
|
So this does not change the URL scheme for now right ? |
|
In a Google+ hangout today we decided to organize things in the following manner: To prevent this from becoming too deeply nested, we are going to move |
|
OK this is ready for final review and merge. The PR follows the design posted above. Test suite passes and notebook runs, but someone should play with it a bit. |
|
read, tested, and played with - looks good to me. 👍 to merge. |
Reorganize the python/server side of the notebook
Organize the JS and less files by component, in the `static` directory of the notebook. This PR does the client side re-org that parallels the server side work in #3321. There are now subdirectories in `static/` for each part of the client; roughly speaking there is one subdir for each page, web service or component.
Reorganize the python/server side of the notebook
Organize the JS and less files by component, in the `static` directory of the notebook. This PR does the client side re-org that parallels the server side work in ipython#3321. There are now subdirectories in `static/` for each part of the client; roughly speaking there is one subdir for each page, web service or component.
This organizes the handlers and managers into subdirs based on the service/component. This is being done in preparation of doing the same thing to the js/less files in static. This should be ready to go.