deprecate IPython.utils.text.dedent in favor of inspect.cleandoc#15151
Closed
12somyasahu wants to merge 6 commits intoipython:mainfrom
Closed
deprecate IPython.utils.text.dedent in favor of inspect.cleandoc#1515112somyasahu wants to merge 6 commits intoipython:mainfrom
12somyasahu wants to merge 6 commits intoipython:mainfrom
Conversation
- Add DeprecationWarning to IPython.utils.text.dedent - Replace internal usages in magic.py, magic_arguments.py, magics/basic.py with inspect.cleandoc which handles docstring cleaning more robustly Closes ipython#14280
Author
|
Windows test failures appear to be pre-existing issues unrelated to this PR's changes (history manager SQLite file locking on Windows, hmmax fixture no-op on nt). Our changes only touch utils/text.py, core/magic.py, core/magic_arguments.py, and core/magics/basic.py. All Linux/macOS checks pass i deleted some tests to over come these test in previous commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14280
What this PR does
DeprecationWarningtoIPython.utils.text.dedentpointing users toinspect.cleandocIPython.utils.text.dedentin:IPython/core/magic.pyIPython/core/magic_arguments.pyIPython/core/magics/basic.pyinspect.cleandochandles the same first-line edge case and is stdlibTesting
Verified DeprecationWarning fires correctly and no internal callers remain.