fix: replace 97 bare except clauses with except Exception#15145
Closed
haosenwang1018 wants to merge 1 commit intoipython:mainfrom
Closed
fix: replace 97 bare except clauses with except Exception#15145haosenwang1018 wants to merge 1 commit intoipython:mainfrom
haosenwang1018 wants to merge 1 commit intoipython:mainfrom
Conversation
Member
|
Please don't do codebase wide search and replace like that; and please show that you have at lease check each of these; some might have to be BaseExecption maybe, and each have to be carefully considered. Please send at max one or two file; I can't review 40+ files at once. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace bare except clauses with except Exception.