Try to close more resouce on windows in system command #14749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c1a25ff to
fa62d22
Compare
There is a resource leak spotted in ipython/ipykernel#1291, that only affects windows, this try to properly close the BufferReader/writrers. I find it weird to have to close things we did not set on the subprocess, I guess this is because it is supposed ot be used as a context manager, unfortunately the CM does .wait(), and we don't want to wait here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a resource leak spotted in ipython/ipykernel#1291, that only
affects windows, this try to properly close the BufferReader/writrers.
I find it weird to have to close things we did not set on the
subprocess, I guess this is because it is supposed ot be used as a
context manager, unfortunately the CM does .wait(), and we don't want to
wait here.