Fix exception causes in 7 modules #12381
Conversation
|
Thanks, will have a look, no need to ping me either, I'll end up looking at PR anyway. |
| except Exception: | ||
| raise ValueError("Precision must be int or format string, not %r"%new) | ||
| except Exception as e: | ||
| raise ValueError("Precision must be int or format string, not %r"%new) from e |
There was a problem hiding this comment.
Thanks, that for example one of the example where I thing "from None" would be useful. The fact that we catch an exception from fmt%3.14159 is an implementation detail, which I think could be hidden from user.
There was a problem hiding this comment.
I understand. I personally hate from None, and I think that when people are debugging they have a very different mindset than when they are writing code. When you're debugging, and you get a very limited amount of information that may have been copy-pasted in an email by a non-technical person, you're very desperate for the information.
In this case, I would have wanted to see the t%3.14159 traceback. I would maybe get a hint on what happened. If it's a dead end for exploration, I at least want to know its content before I rule it out as a dead end.
So I'm a "conscientious objector" to from None. In any of the places I change to from e that you would prefer from None, point them out and I'll just remove my change from that line. I'm okay with someone else making the change to from None, but I don't want to personally be the reason that some developer didn't get the debugging data they wanted.
This is a continuation of #12377 .