8000 Fix test_outstream by davidbrochart · Pull Request #1369 · ipython/ipykernel · GitHub
[go: up one dir, main page]
Skip to content

Fix test_outstream #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: anyio
Choose a base branch
from
Draft

Fix test_outstream #1369

wants to merge 1 commit into from

Conversation

davidbrochart
Copy link
Collaborator

No description provided.

@davidbrochart davidbrochart marked this pull request as draft February 27, 2025 10:48
@davidbrochart
Copy link
Collaborator Author

test_outstream passes but it shouldn't, here is what is printed if pytest -s is used:

Traceback (most recent call last):
  File "/home/runner/work/ipykernel/ipykernel/ipykernel/iostream.py", line 392, in _watch_pipe_fd
    bts = os.read(self._fid, PIPE_BUFFER_SIZE)
AttributeError: 'OutStream' object has no attribute '_fid'

@davidbrochart davidbrochart mentioned this pull request Feb 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@davidbrochart
0