feat(toast): add wrapper and content parts#30737
Merged
brandyscarney merged 6 commits intoionic-team:feature-8.8from Nov 20, 2025
Merged
feat(toast): add wrapper and content parts#30737brandyscarney merged 6 commits intoionic-team:feature-8.8from
brandyscarney merged 6 commits intoionic-team:feature-8.8from
Conversation
|
@Hurubon is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
thetaPC
approved these changes
Nov 19, 2025
Contributor
There was a problem hiding this comment.
LGTM, one question but it's not a blocker
ShaneK
approved these changes
Nov 20, 2025
2 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 5, 2026
Issue number: resolves #30735 --------- ## What is the current behavior? Toast's wrapper and content divs do not have part attributes. ## What is the new behavior? - Adds `wrapper` and `content` parts to Toast. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> ## Other information This PR was originally opened by @Hurubon here in #30737. It was lost in `feature-8.8` due to a bad merge, so this PR is to re-apply this feature so it can go out in 8.8.1 (it was originally supposed to go out in 8.8.0) Co-authored-by: Hurubon <58346722+Hurubon@users.noreply.github.com> Co-authored-by: Hurubon <58346722+Hurubon@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #30735
What is the current behavior?
Toast's wrapper and content divs do not have part attributes.
What is the new behavior?
wrapperandcontentparts to Toast.Does this introduce a breaking change?