chore: add strong types in several places #28781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: Internal
What is the current behavior?
As part of FW-2832 the team has an initiative to remove much of the
anyusage in favor of stronger types. This will make modifications to this codebase safer as we will have access to proper type checking.What is the new behavior?
anyusages in favor of stronger types.Note that not all of the
anytypes within these files have been removed. I mainly stuck to the low hanging fruit 😄Does this introduce a breaking change?
I intentionally made type changes that do not impact public APIs. Any incorrect type changes would cause our CI checks to fail.
Other information