Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 9 commits
- 37 files changed
- 2 contributors
Commits on Jan 3, 2024
-
-
fix(input): slotted buttons are clickable (#28772)
Issue number: resolves #28762 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Focused inputs have `pointer-events: none`. This code was added in e27452b to address #5536. However, this causes slotted buttons to not be clickable when the input is focused because pointer events have been removed. This also causes the input to blur whenever you tap the label text. This behavior only exists on `ion-input`. Textarea is not affected. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> This code was added several years ago for the (now) legacy syntax. I don't have full confidence that this won't break the legacy input because there's not a lot of context around why specifically this code was added. As a result, I scoped these styles only to the legacy input. - Slotted buttons can now be clicked when the input is focused. - Tapping the label when an input is focused keeps the input focused. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> **Testing:** 1. I manually verified that scroll assist still works with the modern input. 2. I manually verified that the input remains focused after tapping the label. Dev build: `7.6.3-dev.11704229014.12cdc767`
Commits on Jan 8, 2024
-
chore: add strong types in several places (#28781)
Issue number: Internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> As part of FW-2832 the team has an initiative to remove much of the `any` usage in favor of stronger types. This will make modifications to this codebase safer as we will have access to proper type checking. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Removed several `any` usages in favor of stronger types. Note that not all of the `any` types within these files have been removed. I mainly stuck to the low hanging fruit 😄 ## Does this introduce a breaking change? - [ ] Yes - [x] No I intentionally made type changes that do not impact public APIs. Any incorrect type changes would cause our CI checks to fail. <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
-
chore(deps): Bump @stencil/core from 4.8.2 to 4.9.0 in /core (#28732)
Bumps [@stencil/core](https://github.com/ionic-team/stencil) from 4.8.2 to 4.9.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil/releases"><code>@stencil/core</code>'s releases</a>.</em></p> <blockquote> <h2>🐏 v4.9.0 (2023-12-18)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>compiler:</strong> fix transforming method parameters into docs (<a href="https://redirect.github.com/ionic-team/stencil/issues/5166">#5166</a>) (<a href="https://github.com/ionic-team/stencil/commit/2d16db6d6e7b1b9559c895d3c7a0970207c0df7f">2d16db6</a>)</li> <li><strong>mock-doc:</strong> add HTMLUListElement (<a href="https://redirect.github.com/ionic-team/stencil/issues/5169">#5169</a>) (<a href="https://github.com/ionic-team/stencil/commit/6233cb5ed8f8767cf69b328adc697b0f70030b6d">6233cb5</a>), closes <a href="https://redirect.github.com/ionic-team/stencil/issues/3382">#3382</a></li> <li><strong>runtime:</strong> allow setting <code>key</code> attr on nested Stencil components (<a href="https://redirect.github.com/ionic-team/stencil/issues/5164">#5164</a>) (<a href="https://github.com/ionic-team/stencil/commit/f6903a86caec1dda655290d99eaf8c42a8e102ac">f6903a8</a>)</li> <li><strong>runtime:</strong> patch <code>removeChild</code> for <code>scoped</code> components (<a href="https://redirect.github.com/ionic-team/stencil/issues/5148">#5148</a>) (<a href="https://github.com/ionic-team/stencil/commit/956c19651772ce1770598e605b6c50e20b39cefa">956c196</a>), closes <a href="https://redirect.github.com/ionic-team/stencil/issues/3278">#3278</a></li> <li><strong>screenshot:</strong> reject pixel match process on exit (<a href="https://redirect.github.com/ionic-team/stencil/issues/5167">#5167</a>) (<a href="https://github.com/ionic-team/stencil/commit/c2ee40db4b515224376b94019067de896d2f1a24">c2ee40d</a>)</li> </ul> <h3>Features</h3> <ul> <li><strong>compiler:</strong> Stencil decorator import aliasing (<a href="https://redirect.github.com/ionic-team/stencil/issues/5161">#5161</a>) (<a href="https://github.com/ionic-team/stencil/commit/97dcb45d44751d239b0afb6380bea217818b211a">97dcb45</a>), closes <a href="https://redirect.github.com/ionic-team/stencil/issues/3137">#3137</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil/blob/main/CHANGELOG.md"><code>@stencil/core</code>'s changelog</a>.</em></p> <blockquote> <h1>🐏 <a href="https://github.com/ionic-team/stencil/compare/v4.8.2...v4.9.0">4.9.0</a> (2023-12-18)</h1> <h3>Bug Fixes</h3> <ul> <li><strong>compiler:</strong> fix transforming method parameters into docs (<a href="https://redirect.github.com/ionic-team/stencil/issues/5166">#5166</a>) (<a href="https://github.com/ionic-team/stencil/commit/2d16db6d6e7b1b9559c895d3c7a0970207c0df7f">2d16db6</a>)</li> <li><strong>mock-doc:</strong> add HTMLUListElement (<a href="https://redirect.github.com/ionic-team/stencil/issues/5169">#5169</a>) (<a href="https://github.com/ionic-team/stencil/commit/6233cb5ed8f8767cf69b328adc697b0f70030b6d">6233cb5</a>), closes <a href="https://redirect.github.com/ionic-team/stencil/issues/3382">#3382</a></li> <li><strong>runtime:</strong> allow setting <code>key</code> attr on nested Stencil components (<a href="https://redirect.github.com/ionic-team/stencil/issues/5164">#5164</a>) (<a href="https://github.com/ionic-team/stencil/commit/f6903a86caec1dda655290d99eaf8c42a8e102ac">f6903a8</a>)</li> <li><strong>runtime:</strong> patch <code>removeChild</code> for <code>scoped</code> components (<a href="https://redirect.github.com/ionic-team/stencil/issues/5148">#5148</a>) (<a href="https://github.com/ionic-team/stencil/commit/956c19651772ce1770598e605b6c50e20b39cefa">956c196</a>), closes <a href="https://redirect.github.com/ionic-team/stencil/issues/3278">#3278</a></li> <li><strong>screenshot:</strong> reject pixel match process on exit (<a href="https://redirect.github.com/ionic-team/stencil/issues/5167">#5167</a>) (<a href="https://github.com/ionic-team/stencil/commit/c2ee40db4b515224376b94019067de896d2f1a24">c2ee40d</a>)</li> </ul> <h3>Features</h3> <ul> <li><strong>compiler:</strong> Stencil decorator import aliasing (<a href="https://redirect.github.com/ionic-team/stencil/issues/5161">#5161</a>) (<a href="https://github.com/ionic-team/stencil/commit/97dcb45d44751d239b0afb6380bea217818b211a">97dcb45</a>), closes <a href="https://redirect.github.com/ionic-team/stencil/issues/3137">#3137</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ionic-team/stencil/commit/448addc17b6e872513a5ad1c3b0c671e81c800e8"><code>448addc</code></a> v4.9.0 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5194">#5194</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/33e930ba1f3a168f697999671f103959b0bb8ee9"><code>33e930b</code></a> chore(repo): revert to artifact actions v3 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5195">#5195</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/6233cb5ed8f8767cf69b328adc697b0f70030b6d"><code>6233cb5</code></a> fix(mock-doc): add HTMLUListElement (<a href="https://redirect.github.com/ionic-team/stencil/issues/5169">#5169</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/964c801c86ce35a75d3d7de39871c6c8fcc272fb"><code>964c801</code></a> chore(snc): resolve final build-finish error (<a href="https://redirect.github.com/ionic-team/stencil/issues/5186">#5186</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/5e9e629180cc3682c0df6446e0eab84f2ab8bd75"><code>5e9e629</code></a> chore(deps): update actions/download-artifact action to v4 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5191">#5191</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/437ce62730b7ecebd4a536128ff12d093199fc3e"><code>437ce62</code></a> chore(deps): update dependency <code>@types/eslint</code> to v8.44.9 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5187">#5187</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/689fbb325f41d95a338a0ac907c46466b9c6d4d2"><code>689fbb3</code></a> chore(deps): update dependency <code>@rollup/plugin-json</code> to v6.1.0 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5190">#5190</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/ccc0000252932cdfbd45f0f56e7bcef9ddd4e079"><code>ccc0000</code></a> chore(deps): update dependency eslint-plugin-jsdoc to v46.9.1 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5188">#5188</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/908886d9467cabe644b6a041f93216c23daf96c0"><code>908886d</code></a> chore(deps): update dependency puppeteer to v21.6.1 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5189">#5189</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/a9c073645216f7afa315c7a0de9601fe20a7c968"><code>a9c0736</code></a> chore(snc): fix some snc errors in puppeteer-emulate.ts (<a href="https://redirect.github.com/ionic-team/stencil/issues/5177">#5177</a>)</li> <li>Additional commits viewable in <a href="https://github.com/ionic-team/stencil/compare/v4.8.2...v4.9.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Commits on Jan 9, 2024
-
chore(deps): Bump @stencil/core from 4.9.0 to 4.9.1 in /core (#28798)
Bumps [@stencil/core](https://github.com/ionic-team/stencil) from 4.9.0 to 4.9.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil/releases"><code>@stencil/core</code>'s releases</a>.</em></p> <blockquote> <h2>🍬 v4.9.1 (2024-01-08)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>declarations:</strong> bundle child_process type for portability (<a href="https://redirect.github.com/ionic-team/stencil/issues/5165">#5165</a>) (<a href="https://github.com/ionic-team/stencil/commit/59ecd9e82ae43e7db67c81959bc34afa0d852087">59ecd9e</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil/blob/main/CHANGELOG.md"><code>@stencil/core</code>'s changelog</a>.</em></p> <blockquote> <h2>🍬 <a href="https://github.com/ionic-team/stencil/compare/v4.9.0...v4.9.1">4.9.1</a> (2024-01-08)</h2> <h3>Bug Fixes</h3> E6C3 <ul> <li><strong>declarations:</strong> bundle child_process type for portability (<a href="https://redirect.github.com/ionic-team/stencil/issues/5165">#5165</a>) (<a href="https://github.com/ionic-team/stencil/commit/59ecd9e82ae43e7db67c81959bc34afa0d852087">59ecd9e</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ionic-team/stencil/commit/be680c691049315c3fa7b9cefdd115489ffed381"><code>be680c6</code></a> v4.9.1 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5240">#5240</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/1ee9641c9b96d14c13f0f07af9cd9d146f13b9a7"><code>1ee9641</code></a> chore(deps): update dependency <code>@types/eslint</code> to v8.56.1 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5233">#5233</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/acbaaa87ef7a26b72d983bdbe4d90b23da7a18a9"><code>acbaaa8</code></a> chore(deps): update dependency eslint-plugin-jest to v27.6.1 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5235">#5235</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/11f7fd23dc7b95f88f87489b428f026697a556f0"><code>11f7fd2</code></a> chore(deps): update dependency eslint-plugin-jsdoc to v46.10.1 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5237">#5237</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/be8b4593c7280ef20a808d722a9de269de6a7070"><code>be8b459</code></a> chore(deps): update dependency esbuild to v0.19.11 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5224">#5224</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/8f80d5d34a3cb528427f8b673947def7ca8efb3d"><code>8f80d5d</code></a> chore(deps): update dependency cspell to v8.3.0 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5226">#5226</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/336a40c989947313a91e2ae4b362139a03657c16"><code>336a40c</code></a> chore(deps): update dependency dts-bundle-generator to ~9.2.0 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5227">#5227</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/533fb30746dfb76d8b418eaf07d9d016f5f10cf7"><code>533fb30</code></a> chore(deps): update dependency <code>@types/node</code> to v20.10.6 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5223">#5223</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/e4f1c420e550d324a81fa4b86756955bd1104756"><code>e4f1c42</code></a> Compile pixel-match file correctly (<a href="https://redirect.github.com/ionic-team/stencil/issues/5199">#5199</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/d4f790f5059636ff344f41015d8ae9da6b2b04a6"><code>d4f790f</code></a> chore(esbuild): ensure that output dirs are empty before we run esbuild (<a href="https://redirect.github.com/ionic-team/stencil/issues/5219">#5219</a>)</li> <li>Additional commits viewable in <a href="https://github.com/ionic-team/stencil/compare/v4.9.0...v4.9.1">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
-
chore(ci): checkout files when updating package-lock (#28778)
In #28697 I moved the package-lock work to its own step to lets us re-run that if it fails. However, I forgot to checkout the project files in that step, so there was no `package-lock.json` file to update [resulting in an error](https://github.com/ionic-team/ionic-framework/actions/runs/7398703880/job/20128761433).
Commits on Jan 10, 2024
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v7.6.3...v7.6.4