8000 add requests.Session to support keep-alive by muzhig · Pull Request #142 · intercom/python-intercom · GitHub
[go: up one dir, main page]

Skip to content

add requests.Session to support keep-alive#142

Closed
muzhig wants to merge 1 commit intointercom:masterfrom
muzhig:master
Closed

add requests.Session to support keep-alive#142
muzhig wants to merge 1 commit intointercom:masterfrom
muzhig:master

Conversation

@muzhig
Copy link
@muzhig muzhig commented Jan 6, 2017

@muzhig
Copy link
Author
muzhig commented Jan 6, 2017

Something not good with CI, pip fails. Not connected with my pull requests.
aka "works on my machine"

@jkeyes
Copy link
Contributor
jkeyes commented Feb 6, 2017

Even if the pip command worked (not sure why it didn't), the tests in test_request.py would fail.

I've had a little look at it, and I think the correct place for doing it is to have a session per client, rather than having it at the Request class level. See #146.

@jkeyes jkeyes closed this Feb 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0