8000 Make object_qsort generic in arrsize type by r-devulap · Pull Request #207 · intel/x86-simd-sort · GitHub
[go: up one dir, main page]
Skip to content

Make object_qsort generic in arrsize type #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make object_qsort generic in arrsize type #207

wants to merge 2 commits into from

Conversation

r-devulap
Copy link
Contributor

Support for 32-bit and 64-bit integer types for arrsize: Updated the object_qsort function to accept arrsize as any 32-bit or 64-bit integer type by introducing a new template parameter U. Updated README to reflect these changes.

Fixes #206

r-devulap added 2 commits May 20, 2025 11:59
@r-devulap
Make object_qsort fully generic in arrsize type
1891087 
- Change arrsize parameter and all related indexing/size variables in
  object_qsort to use a template parameter ArrSize instead of fixed-size
  types.
- Add static_asserts to ensure ArrSize and key_func return type are
  either 32-bit or 64-bit.
- Change the type of the arg vector from uint32_t to ArrSize for
  consistency and correctness.
@r-devulap
update README
d96f088
@r-devulap r-devulap mentioned this pull request May 20, 2025
Open
sterrettm2
sterrettm2 reviewed May 30, 2025
View reviewed changes
Copy link
Contributor
@sterrettm2 sterrettm2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall; my only comment is that I don't think the name U is good for the type used for indices, especially as it shows up in the public-facing API. I think it should probably have a more relevant name. Besides that, this looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sterrettm2 sterrettm2 sterrettm2 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

64-bit object_qsort
2 participants
@r-devulap @sterrettm2
0