8000 fix(agent): Set `godebug x509negativeserial=1` as a workaround by DStrand1 · Pull Request #16489 · influxdata/telegraf · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(agent): Set godebug x509negativeserial=1 as a workaround #16489

Merged
merged 1 commit into from
Feb 10, 2025
Merged

fix(agent): Set godebug x509negativeserial=1 as a workaround #16489

merged 1 commit into from
Feb 10, 2025

Conversation

DStrand1
Copy link
Member
@DStrand1 DStrand1 commented Feb 6, 2025

Summary

Works around an issue with negative and oversize x509 certificate serial numbers to restore behavior from before Go 1.23. Long term I am communicating with the Go team to see if there is a better solution

Checklist

  • No AI generated code was used in this PR

Related issues

Related to #16309

@DStrand1 DStrand1 self-assigned this Feb 6, 2025
@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Feb 6, 2025
@telegraf-tiger
Copy link
Contributor
telegraf-tiger bot commented Feb 6, 2025

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

srebhan
srebhan approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member
@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @DStrand1!

@srebhan srebhan added area/agent go Pull requests that update Go code ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Feb 10, 2025
@srebhan srebhan merged commit 5f4ee87 into influxdata:master Feb 10, 2025
26 of 27 checks passed
@github-actions github-actions bot added this to the v1.33.2 milestone Feb 10, 2025
srebhan pushed a commit that referenced this pull request Feb 10, 2025
@DStrand1 @srebhan
fix(agent): Set godebug x509negativeserial=1 as a workaround (#16489)
4e7a3a9 
(cherry picked from commit 5f4ee87)
@BrewTestBot B 8041 rewTestBot mentioned this pull request Feb 10, 2025
Merged
@srebhan srebhan mentioned this pull request Feb 17, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

Assignees

@DStrand1 DStrand1

Labels
area/agent fix pr to fix corresponding bug go Pull requests that update Go code ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.33.2
Development

Successfully merging this pull request may close these issues.
2 participants
@DStrand1 @srebhan
0