This repository was archived by the owner on Oct 29, 2024. It is now read-only.
Make the pandas client easy to use, and fix the precision invalids #555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally, the setting is use the list to confirm the precision issue, ['n', 'u', 'ms', 's', 'm', 'h', 'N', None]. However, i change the list to another form, ['n', 'u' 8000 , 'ms', 's', 'm', 'h', 'N', 'U', 'L', 'S', 'M', 'H', None], because the pandas have some different in mine work. Pandas version: 0.22.0 OS: OS X.
sebito91
suggested changes
Apr 10, 2020
There was a problem hiding this comment.
Thanks a lot for your commit @SatoshiNewton, though I have to be honest I'm not sure exactly what we're solving for here.
Can you please give an example of where/when you're seeing issues that would make these changes necessary?
| @@ -492,7 +492,7 @@ def _write_points(self, | |||
| retention_policy, | |||
| tags, | |||
| protocol='json'): | |||
| if time_precision not in ['n', 'u', 'ms', 's', 'm', 'h', None]: | |||
| if time_precision not in ['n', 'u', 'ms', 's', 'm', 'h', 'N', 'U', 'L', 'S', 'M', 'H', None]: | |||
There was a problem hiding this comment.
I'm not sure what these extra time precision components are meant to be?
|
Closing for now, please let me know if this is an important fix and we can re-open! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here, I just make the pandas dataframe client convert the key to string automatically.
Further more, I found the example have a problem about time_precision.
The time_precision of dataframe client required the lower word, but pandas automatically make the freq in upper word.
I am not pretty sure did that's relative with the update of pandas, but I fixed it with consider about upper word and lower word at the same time.