8000 Dont include empty tags in lines (Closes: #215) by aviau · Pull Request #216 · influxdata/influxdb-python · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Oct 29, 2024. It is now read-only.

Dont include empty tags in lines (Closes: #215) #216

Merged
merged 1 commit into from
Jul 19, 2015
Merged

Dont include empty tags in lines (Closes: #215) #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions influxdb/line_protocol.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,10 @@ def make_lines(data):
tags.update(point.get('tags', {}))
# tags should be sorted client-side to take load off server
for tag_key in sorted(tags.keys()):
lines += "{key}={value},".format(
key=_escape_tag(tag_key),
value=_escape_tag(tags[tag_key]),
)
key = _escape_tag(tag_key)
value = _escape_tag(tags[tag_key])
if key != '' and value != '':
lines += "{key}={value},".format(key=key, value=value)
lines = lines[:-1] + " " # strip the trailing comma

# add fields
Expand Down
27 changes: 27 additions & 0 deletions tests/influxdb/test_line_protocol.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# -*- coding: utf-8 -*-

import unittest
from influxdb import line_protocol


class TestLineProtocol(unittest.TestCase):

def test_empty_tag(self):
data = {
"tags": {
"my_tag": ""
},
"points": [
{
"measurement": "test",
"fields": {
"value": "hello!"
}
}
]
}

self.assertEqual(
line_protocol.make_lines(data),
'test value="hello!"\n'
)
0