10000 fix(core): repair sanitizing of numbers and regular expressions by sranka · Pull Request #468 · influxdata/influxdb-client-js · GitHub
[go: up one dir, main page]
Skip to content

fix(core): repair sanitizing of numbers and regular expressions #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 13, 2022
Merged

fix(core): repair sanitizing of numbers and regular expressions #468

merged 6 commits into from
Jul 13, 2022

Conversation

sranka
Copy link
Contributor
@sranka sranka commented Jul 13, 2022 •
edited
Loading

Fixes #467

Sanitizing of JS values to flux values is revised herein.

Proposed Changes

This PR fixes sanitizing of flux values so that

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • yarn test completes successfully
  • Commit messages are conventional

@sranka sranka added this to the 1.28.0 milestone Jul 13, 2022
@sranka sranka requested review from vlastahajek and bednar July 13, 2022 05:52
@sranka sranka changed the title fix(core): improve sanitizing of number and regexp values fix(core): repair sanitizing of numbers and regular expressions Jul 13, 2022
@sranka sranka marked this pull request as ready for review July 13, 2022 06:00
@codecov-commenter
Copy link

Codecov Report

Merging #468 (e6f5f7f) into master (a1ffdad) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #468   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           33        33           
  Lines         1240      1254   +14     
  Branches       294       301    +7     
=========================================
+ Hits          1240      1254   +14
Impacted Files Coverage Δ
packages/core/src/query/flux.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1ffdad...e6f5f7f. Read the comment docs.

bednar
bednar approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor
@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍻

@sranka sranka merged commit 4381433 into master Jul 13, 2022
@sranka sranka deleted the 467/sanitize_better branch July 13, 2022 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bednar bednar bednar approved these changes

@vlastahajek vlastahajek Awaiting requested review from vlastahajek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.28.0
Development

Successfully merging this pull request may close these issues.

fluxFloat does not return valid float when the value is a number without a decimal part
3 participants
@sranka @codecov-commenter @bednar
0