8000 fix: serialization of `\n`, `\r` and `\t` to Line Protocol by bednar · Pull Request #205 · influxdata/influxdb-client-js · GitHub
[go: up one dir, main page]
Skip to content

fix: serialization of \n, \r and \t to Line Protocol #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 29, 2020
Merged

fix: serialization of \n, \r and \t to Line Protocol #205

merged 3 commits into from
Jun 29, 2020

Conversation

bednar
Copy link
Contributor
@bednar bednar commented Jun 25, 2020 •
edited
Loading

Related to influxdata/influxdb-client-java#127

Checklist

  • CHANGELOG.md updated
  • A test has been added if appropriate
  • yarn test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar requested a review from sranka June 25, 2020 08:53
< 8000 /div>
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@e72a68d). Click here to learn what that means.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #205   +/-   ##
=========================================
  Coverage          ?   99.88%           
=========================================
  Files             ?       26           
  Lines             ?      897           
  Branches          ?      194           
=========================================
  Hits              ?      896           
  Misses            ?        1           
  Partials          ?        0
Impacted Files Coverage Δ
packages/core/src/util/escape.ts 96.42% <90.90%> (ø)
packages/core/src/errors.ts 100.00% <0.00%> (ø)
packages/core/src/impl/ObservableQuery.ts 100.00% <0.00%> (ø)
packages/core/src/impl/linesToTables.ts 100.00% <0.00%> (ø)
packages/core/src/impl/pureJsChunkCombiner.ts 100.00% <0.00%> (ø)
packages/core/src/impl/QueryApiImpl.ts 100.00% <0.00%> (ø)
packages/core/src/query/flux.ts 100.00% <0.00%> (ø)
packages/core/src/impl/browser/FetchTransport.ts 100.00% <0.00%> (ø)
packages/core/src/util/currentTime.ts 100.00% <0.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e72a68d...3e0f6e4. Read the comment docs.

sranka
sranka reviewed Jun 25, 2020
View reviewed changes
Copy link
Contributor
@sranka sranka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that the documentation at https://v2.docs.influxdata.com/v2.0/reference/syntax/line-protocol/#special-characters is incomplete or misleading. We should have some clarification from the server-side, do we already?

@bednar
Copy link
Contributor Author
bednar commented Jun 25, 2020

No, the solution comes from old python client: influxdata/influxdb-python#716

@bednar bednar force-pushed the fix/escaping-characters branch from 23525d2 to 7e35d26 Compare June 29, 2020 08:43
@bednar bednar merged commit 6673bad into master Jun 29, 2020
@bednar bednar deleted the fix/escaping-characters branch June 29, 2020 08:44
@bednar bednar added this to the 1.5.0 milestone Jun 29, 2020
@cTn-dev cTn-dev mentioned this pull request Aug 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sranka sranka sranka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bednar @codecov-commenter @sranka
0