Remove all intermediate files in same layers#635
Open
ypnos wants to merge 1 commit intoinfluxdata:masterfrom
Open
Remove all intermediate files in same layers#635ypnos wants to merge 1 commit intoinfluxdata:masterfrom
ypnos wants to merge 1 commit intoinfluxdata:masterfrom
Conversation
wborn
reviewed
Aug 26, 2022
influxdb/2.3/Dockerfile
Outdated
| gpg --batch --verify influxdb2-${INFLUXDB_VERSION}-linux-${ARCH}.tar.gz.asc influxdb2-${INFLUXDB_VERSION}-linux-${ARCH}.tar.gz && \ | ||
| tar xzf influxdb2-${INFLUXDB_VERSION}-linux-${ARCH}.tar.gz && \ | ||
| cp influxdb2_linux_${ARCH}/influxd /usr/local/bin/influxd && \ | ||
| rm -rf influxdb2-* && \ |
There was a problem hiding this comment.
I think it should also remove influxdb2_linux_${ARCH} here. 🙃
Author
There was a problem hiding this comment.
Thanks for the review. I'm braindead!
- Remove untarred files that were previously missed by glob - Remove files in layer they originate from This is in line with the approach in telegraf's Dockerfiles
wborn
approved these changes
Aug 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR is for #624
This is in line with the approach in telegraf's Dockerfiles.