8000 Adding a default export to the flow definition file by rtorr · Pull Request #935 · immutable-js/immutable-js · GitHub
[go: up one dir, main page]
Skip to content

Adding a default export to the flow definition file #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Adding a default export to the flow definition file #935

wants to merge 1 commit into from

Conversation

rtorr
Copy link
@rtorr rtorr commented Jul 28, 2016 •
edited
Loading

Unfortunately, in the project I am using does not support named imports https://github.com/ef4/ember-browserify#known-caveats

Willing to change what I did if needed!

@ghost ghost added the CLA Signed label Jul 28, 2016
@wokalski
Copy link
Contributor

@rtorr This repo is not actively maintained as far as I can see. I created a PR in flow-typed to add flow definitions for immutable there.

My fork is here. Feel free to submit a PR with your changes there.

@lacker lacker added the flow label Dec 6, 2016
@lacker
Copy link
lacker commented Dec 6, 2016

Does this PR still make sense now that we merged #878 ?

@wokalski
Copy link
Contributor
wokalski commented Dec 6, 2016 •
edited
Loading

I think I fixed it. The test passes.

@rtorr
Copy link
Author
rtorr commented Dec 6, 2016

It still does not have a default export if i am reading that correctly.

@wokalski
Copy link
Contributor
wokalski commented Dec 7, 2016

The default export is immutable module.

@lacker
Copy link
lacker commented Dec 15, 2016

Since the tests now check that Flow works with:

import Immutable, {
  List,
  Map,
  Stack,
  Set,
  KeyedIterable,
  Range,
  Repeat,
  IndexedSeq
} from 'immutable'

it seems like this functionality is now in master. So I am going to close this pull request, but if you think I'm making a mistake please feel free to discuss/object/etc. Thanks for submitting this pr!

@lacker lacker closed this Dec 15, 2016
@rtorr rtorr deleted the adding-default-exports-flowtype branch December 16, 2016 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed flow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rtorr @wokalski @lacker @facebook-github-bot
0