Speed up TypeScript compilation when running test suite #416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Speed up the test suite by updating to the current version of the TypeScript compiler which is ~5x faster than the 1.0 version that was being used previously and caching compiled TypeScript files. * Update type definitions and flatten.ts for compatibility with TS 1.4 * Remove ts-compiler dependency and use the now-public TypeScript compiler API directly. Fixes immutable-js#399
|
There are some failing tests because of this change. What's the reason for that? |
added 3 commits
March 26, 2015 19:25
The test comment indicated that one trailing hole was expected but the argument to toEqual() had two. This used to pass previously due to an emission bug in the TypeScript 1.0 compiler which is fixed in TS 1.4
| @@ -31,7 +31,7 @@ describe('slice', () => { | |||
| it('slices a sparse indexed sequence', () => { | |||
| expect(Seq([1,,2,,3,,4,,5,,6]).slice(1).toArray()).toEqual([,2,,3,,4,,5,,6]); | |||
| expect(Seq([1,,2,,3,,4,,5,,6]).slice(2).toArray()).toEqual([2,,3,,4,,5,,6]); | |||
| expect(Seq([1,,2,,3,,4,,5,,6]).slice(3, -3).toArray()).toEqual([,3,,4,,,]); // one trailing hole. | |||
| expect(Seq([1,,2,,3,,4,,5,,6]).slice(3, -3).toArray()).toEqual([,3,,4,,]); // one trailing hole. | |||
There was a problem hiding this comment.
I guess TypeScript changed their rules around trailing comma removal in 1.4?
leebyron
added a commit
that referenced
this pull request
Mar 26, 2015
Speed up TypeScript compilation when running test suite
|
Nice work! |
Looks to me like it was simply a bug that got fixed. Thanks for the quick review! |
|
I'm having trouble getting started with contribution to the project. My first time trying to run tests failed. I tried with the tag prior to this change and all was fine. I just filed an issue for it #431 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speed up the test suite by updating to the current version
of the TypeScript compiler which is ~5x faster than the 1.0
version that was being used previously and caching compiled
TypeScript files.
with TS 1.4
compiler API directly.
Fixes #399
With these changes a full run of the test suite on my laptop goes from ~100s to ~20s on first run and ~10s for subsequent runs where the test files have not changed.
There is currently a test failure in slice.ts which I'm looking into