8000 Fix typo by drabinowitz · Pull Request #345 · immutable-js/immutable-js · GitHub
[go: up one dir, main page]
Skip to content

Fix typo #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix typo #345

wants to merge 1 commit into from

Conversation

drabinowitz
Copy link

Currently the example in the README.md shows assert(map1 === map2). This is confusing for readers since these two are not equal, but we assert that they are. This change adjusts the example to assert the reality.

@tgriesser
Copy link
Contributor

In this case the two are actually equal though, map1.set('b', 2) is a no-op because the value of 'b' is already 2, so it's just smart enough to return the same value.

@drabinowitz
Copy link
Author

Of course my mistake thank you. I wonder if an inline comment wouldn't help to clarify that fact.

@leebyron
Copy link
Collaborator

Sorry, the hope was the assert() was illustrating that point, but I suppose the text could be more verbose.

@leebyron leebyron closed this in d6086b3 Feb 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drabinowitz @tgriesser @leebyron
0