8000 Overhaul flow type definitions for Record by leebyron · Pull Request #1104 · immutable-js/immutable-js · GitHub
[go: up one dir, main page]

Skip to content

Overhaul flow type definitions for Record #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2017
Merged

Conversation

leebyron
Copy link
Collaborator
@leebyron leebyron commented Mar 7, 2017

Fixes #992
Closes #876

@leebyron leebyron merged commit b20892d into master Mar 8, 2017
@leebyron leebyron deleted the record-flowtype branch March 8, 2017 03:14
@rgbkrk
Copy link
Contributor
rgbkrk commented Mar 8, 2017

Thank you! Do you think this is the limit of where these flow definitions can get with current flow primitives?

@leebyron
Copy link
Collaborator Author
leebyron commented Mar 8, 2017

As far as I can tell yes, though if you're able to squeeze out any improvements that I missed, send a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0