8000 Fix boolean values not displayed by jdeniau · Pull Request #8 · immutable-js/immutable-devtools · GitHub
[go: up one dir, main page]
Skip to content

Fix boolean values not displayed #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdeniau merged 1 commit into from
Dec 9, 2025
Merged

Fix boolean values not displayed #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/devtools/demo/demo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,3 +83,16 @@ console.log(
);

console.log('Range', Immutable.Range(0, 10, 2));

console.log(
'List of scalars',
Immutable.List([
true,
false,
1,
'a',
Symbol('sym'),
new Date(),
BigInt(12345),
])
);
75 changes: 74 additions & 1 deletion packages/devtools/src/createFormatter.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ describe('List', () => {
const list = List();

const { ListFormatter } = createFormatters({ List, isList });

const formatted = ListFormatter.header(list);
expect(formatted).toEqual([
'span',
Expand All @@ -23,4 +23,77 @@ describe('List', () => {
]);
expect(ListFormatter.hasBody(list)).toBe(false);
});

test('List with scalar values', () => {
const list = List([true, false, 1, 'a']);

const { ListFormatter } = createFormatters({ List, isList });

const formatted = ListFormatter.header(list);
expect(formatted).toEqual([
'span',
[
'span',
{
style:
'color: light-dark(rgb(232,98,0), rgb(255, 150, 50)); position: relative',
},
'List',
],
['span', `[${list.size}]`],
]);
expect(ListFormatter.hasBody(list)).toBe(true);

expect(ListFormatter.body!(list)).toEqual([
'ol',
{
style:
'list-style-type: none; padding: 0; margin: 0 0 0 12px; font-style: normal; position: relative',
},
[
'li',
['span', { style: 'color: light-dark( #881391, #D48CE6)' }, '0: '],
[
'span',
{
style: 'color: light-dark(rgb(28, 128, 28), rgb(50, 200, 50))',
},
'true',
],
],
[
'li',
['span', { style: 'color: light-dark( #881391, #D48CE6)' }, '1: '],
[
'span',
{
style: 'color: light-dark(rgb(28, 128, 28), rgb(50, 200, 50))',
},
'false',
],
],
[
'li',
['span', { style: 'color: light-dark( #881391, #D48CE6)' }, '2: '],
[
'span',
{
style: 'color: light-dark(rgb(28, 128, 28), rgb(50, 200, 50))',
},
1,
],
],
[
'li',
['span', { style: 'color: light-dark( #881391, #D48CE6)' }, '3: '],
[
'object',
{
config: undefined,
object: 'a',
},
],
],
]);
});
});
19 changes: 16 additions & 3 deletions packages/devtools/src/createFormatters.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
const orange = 'light-dark(rgb(232,98,0), rgb(255, 150, 50))';
const purple = 'light-dark( #881391, #D48CE6)';
const gray = 'light-dark(rgb(119,119,119), rgb(201, 201, 201))';
const green = 'light-dark(rgb(28, 128, 28), rgb(50, 200, 50))';

const listStyle = {
style:
Expand All @@ -16,6 +17,7 @@ const inlineValuesStyle = {
style: `color: ${gray}; font-style: italic; position: relative`,
};
const nullStyle = { style: `color: ${gray}` };
const numberBooleanStyle = { style: `color: ${green}` };

export type DevToolsFormatter = {
header: (object: any, config?: any) => any;
Expand Down Expand Up @@ -63,8 +65,16 @@ export default function createFormatters(
};

const reference = (object: any, config?: any) => {
if (typeof object === 'undefined') return ['span', nullStyle, 'undefined'];
else if (object === null) return ['span', nullStyle, 'null'];
if (typeof object === 'undefined') {
return ['span', nullStyle, 'undefined'];
} else if (object === null) {
return ['span', nullStyle, 'null'];
} else if (typeof object === 'boolean') {
return ['span', numberBooleanStyle, object ? 'true' : 'false'];
} else if (typeof object === 'number') {
return ['span', numberBooleanStyle, object];
}

return ['object', { object, config }];
};

Expand Down Expand Up @@ -163,7 +173,10 @@ export default function createFormatters(

const ListFormatter: DevToolsFormatter = {
header(o: any) {
if (!Immutable.isList(o)) return null;
if (!Immutable.isList(o)) {
return null;
}

return renderIterableHeader(o, 'List');
},
hasBody,
Expand Down
0