fix upcoming type error #6460
Merged
fix upcoming type error #6460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, @Dreamsorcerer , thanks for the PR! We use conventional commits on the project -- you can check out https://ibis-project.org/community/contribute/02_workflow/#writing-the-commit for more info on commit message formatting. |
|
Can you just squash merge and save me needing to figure out how to rewrite the history? |
Update egraph.py
cpcloud
approved these changes
Jun 16, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mypy expects the type to be annotated as
object.This will cause an error in the next release due to
__eq__()being added to Mapping in typeshed:python/typeshed#10297 (comment)