Added tabTitle argument for iSEE#693
Merged
federicomarini merged 1 commit intoiSEE:develfrom Apr 14, 2025
Merged
Conversation
10 tasks
Contributor
|
I am guessing this is related to this #682 but not fully addressed, correct? |
Contributor
Author
|
Yes #682 added support for HTML elements as app title, but then the browser tab is not rendered neatly when using HTML elements as app title. |
Contributor
|
We could have some alternative with respect to the default value of Thanks for the contribution @RiboRings ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
As discussed in the miaDash submission to Bioc, the tab title for miaDash is currently derived from the
dashboardHeadertitle and therefore is not rendered correctly when the title is an HTML element, like for miaDash.Therefore, I added a new argument to the
iSEEfunction calledtabTitle, which lets you modify the name of the browser tab without affecting the app title or other elements. For example, for the ISEE app:Feel free to let me know if this solution suits iSEE and if anything should be changed.
Best,
Giulio