Conversation
- adding the constants - change the documentation to reflect the additional option
Contributor
Author
Member
|
babysitting duty tonight - i was almost looking forward to coding that one myself, but lack time and energy and appreciate that you did it ;) |
|
Friendly reminder for reviewers to check out the PR. Would be nice to have this on devel this week. |
Member
|
On it today. Just gotta bring my |
Member
|
Indeed it works, but I noticed that in the code tracker, the following line then becomes effectively redundant guides(colour = guide_legend(override.aes = list(size=1)), fill = guide_legend(override.aes = list(size=1))) +I guess that can be adjusted later, as long as the expected behaviour is implemented. I'm just too short on time right now to do that carefully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the option to have NO legend on the DotPlot panels