Add cp and mv commands#30
Open
isaacgravenortechnologies wants to merge 5 commits intoiProgramMC:masterfrom
Open
Add cp and mv commands#30isaacgravenortechnologies wants to merge 5 commits intoiProgramMC:masterfrom
isaacgravenortechnologies wants to merge 5 commits intoiProgramMC:masterfrom
Conversation
This commit adds 'cp' and 'mv', where 'mv' uses the same code as 'cp' but attempts to delete the file afterwards. Command-line fkags (such as -r ), or moving/copying folders isn't supported by this code (yet!).
iProgramMC
requested changes
Mar 10, 2025
Yet to do: block reading, FiRenameFile
Used movedata code for cp (and for the second attempt of mv, where it copies/deletes), reusing movedata_precision for cp and mv by defining it up top.
iProgramMC
reviewed
Mar 11, 2025
Merge fixes from upstream
The code styles were all sorted out, and after having looked into other source files, size_t seems to be pointless here so int has been used instead, with casts removed where appropriate. Also, '||' has been added when checking filenames, as suggested.
Author
|
I believe all of the reviewed points have been addressed, save for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit/PR adds 'cp' and 'mv', where 'mv' uses the same code as 'cp' but attempts to delete the file afterwards. Command-line fkags (such as -r ), or moving/copying folders isn't supported by this code (yet!).