8000 Fix build errors on Mac OSX 10.8 by ville-k · Pull Request #2 · hypertable/hypertable · GitHub
[go: up one dir, main page]
Skip to content

Fix build errors on Mac OSX 10.8 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ville-k wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix build errors on Mac OSX 10.8 #2

ville-k wants to merge 1 commit into from

Conversation

@ville-k
Copy link
@ville-k ville-k commented Oct 29, 2012

These changes fix build errors (but not warnings) on OSX 10.8 with compiler:

Apple clang version 4.1 (tags/Apple/clang-421.11.66) (based on LLVM 3.1svn

Only one (Blob::size vs Blob::size()) of the fixed build errors looked worrisome.

  • access Blob::size member variable instead of
    calling non-existent function Blob::size()
  • specify template base class (Allocator) when
    calling it's functions from a subclass
  • remove duplicate declaration of a function and
    change the declaration to use correct type
  • wrap overloaded std::string operators inside the
    std namespace

@ville-k
Fix build errors on Mac OSX 10.8 + Xcode 4.5.1
4f5c29a 
* access Blob::size member variable instead of
  calling non-existent function Blob::size()
* specify template base class (Allocator) when
  calling it's functions from a subclass
* remove duplicate declaration of a function and
  change the declaration to use correct type
* wrap overloaded std::string operators inside the
  std namespace
@nuggetwheat nuggetwheat force-pushed the master branch 3 times, most recently from 3e1bbf7 to a42b3e1 Compare October 8, 2014 18:50
@nuggetwheat nuggetwheat force-pushed the master branch 8 times, most recently from c7bd5de to dcfe39d Compare October 28, 2014 16:17
@nuggetwheat nuggetwheat mentioned this pull request Feb 25, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ville-k
0