Updating hyperlight-wasm crate features so mshv3 is the default (instead of mshv2)#125
Closed
marosset wants to merge 1 commit intohyperlight-dev:mainfrom
Closed
Updating hyperlight-wasm crate features so mshv3 is the default (instead of mshv2)#125marosset wants to merge 1 commit intohyperlight-dev:mainfrom
marosset wants to merge 1 commit intohyperlight-dev:mainfrom
Conversation
Member
|
@marosset I think you need to bump the hyperlight-host dependency here for this to work. If you do, please bump all the other revs that refer to https://github.com/hyperlight-dev/hyperlight at the same time, including the ones in wasm_runtime and hyperlight_wasm_macro. |
Contributor
|
I rebased #128 on your commit, CI on my PR was struggling otherwise. |
Member
…ead of mshv2) Signed-off-by: Mark Rossett <marosset@microsoft.com>
Contributor
Author
Contributor
|
Closing this since #128 merged, hope that's fine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up from hyperlight-dev/hyperlight#703