Fix Windows build with --no-default-features#712
Merged
danbugs merged 3 commits intohyperlight-dev:mainfrom Jul 15, 2025
Merged
Fix Windows build with --no-default-features#712danbugs merged 3 commits intohyperlight-dev:mainfrom
--no-default-features#712danbugs merged 3 commits intohyperlight-dev:mainfrom
Conversation
ludfjig
previously approved these changes
Jul 11, 2025
Contributor
There was a problem hiding this comment.
Looks good! I think we should strive to set the same registers on all hypervisors, so we don't rely on any inherent defaults of a particular hv. Thoughts?
c8511cc to
fe110fb
Compare
Contributor
Author
Probably a good idea—we should also avoid relying on This is exactly the setup we needed w/o Might be a good work item for #469? |
2c28574 to
85e2184
Compare
syntactically
previously approved these changes
Jul 11, 2025
dblnz
previously approved these changes
Jul 14, 2025
marosset
previously approved these changes
Jul 14, 2025
97b3e43
Signed-off-by: danbugs <danilochiarlone@gmail.com>
+ on Linux w/o init-paging but some driver Signed-off-by: danbugs <danilochiarlone@gmail.com>
…ture Signed-off-by: danbugs <danilochiarlone@gmail.com>
97b3e43 to
27c01ea
Compare
dblnz
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #685 and updates CI to ensure Windows builds successfully without default features.
Btw, to validate this fix, I tested running Nanvix (which uses
--no-default-features) on Windows as a guest. This revealed that additional register setup was needed inhyperv_windows.rs:Limitparameter for CS to0xFFFF(required when paging isn't initialized)These changes ensure Windows Hyper-V properly initializes guest VMs that don't use the init-paging feature. Same idea for Linux Hyper-V too.