Removing HostFunctionDefinitions region#453
Merged
danbugs merged 2 commits intohyperlight-dev:mainfrom May 2, 2025
Merged
Conversation
ludfjig
previously approved these changes
May 2, 2025
…nDefinitions memory region We only used the HostFunctionDefinitions region to validate that a host function exists before calling it. But, if the host function doesn't exist, we'll just exit anyway, so that utility is questionable. Signed-off-by: danbugs <danilochiarlone@gmail.com>
Because we no longer need to serialize those structures, I updated our flatbuffer schema. Signed-off-by: danbugs <danilochiarlone@gmail.com>
136c908 to
af6c1a9
Compare
ludfjig
approved these changes
May 2, 2025
Contributor
There was a problem hiding this comment.
LGTM! Feel free to ignore nit
danbugs
added a commit
to danbugs/hyperlight
that referenced
this pull request
May 6, 2025
Removed cfg options that became unused after PRs hyperlight-dev#451 , hyperlight-dev#453 , and hyperlight-dev#457 merged. Signed-off-by: danbugs <danilochiarlone@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We only used the
HostFunctionDefinitionsregion to validate that a host function exists before calling it. But, if the host function doesn't exist, we'll just exit anyway, so that utility is questionable. Also, with the removal of the region, because we no longer need to serialize thehost_function_*structures, I updated our Flatbuffer schema.