Merged
Conversation
ludfjig
previously approved these changes
Mar 9, 2026
syntactically
previously approved these changes
Mar 9, 2026
Member
There was a problem hiding this comment.
I think the interface to this will be a bit messy on Windows, where the user will have to provide the handle themselves. That's fine for now though I think. Happy to merge ASAP.
1b294f6 to
80bc52c
Compare
Hyperlight-wasm requires this for memory mapping in the modules. This was removed during an early iteration where this did not work but now that CoW has been released this can be exposed again for use in HL-wasm Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
80bc52c to
813dae1
Compare
syntactically
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hyperlight-wasm requires this for memory mapping in the components. This was removed during an early iteration where this did not work but now that CoW has been released this can be exposed again for use in HL-wasm
#1293