8000 fix: flaky gdb test by jsturtevant · Pull Request #1247 · hyperlight-dev/hyperlight · GitHub
[go: up one dir, main page]
Skip to content

fix: flaky gdb test #1247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsturtevant merged 2 commits into from
Feb 20, 2026
Merged

fix: flaky gdb test #1247

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ca66a2
fix(examples): fix flaky gdb test
jsturtevant Feb 19, 2026
fcda1a7
Merge branch 'main' into squad/1061-fix-flaky-gdb-test
jsturtevant Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 9 additions & 18 deletions src/hyperlight_host/examples/guest-debugging/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,16 +234,13 @@ mod tests {
}
}

fn cleanup(out_file_path: &str, cmd_file_path: &str) -> Result<()> {
let res1 = std::fs::remove_file(out_file_path)
.map_err(|e| new_error!("Failed to remove gdb.output file: {}", e));
let res2 = std::fs::remove_file(cmd_file_path)
.map_err(|e| new_error!("Failed to remove gdb-commands.txt file: {}", e));

res1?;
res2?;

Ok(())
fn cleanup(out_file_path: &str, cmd_file_path: &str) {
// Ignore missing files — they may not exist if the test failed early.
for path in [out_file_path, cmd_file_path] {
if let Err(e) = std::fs::remove_file(path) {
println!("Warning: failed to remove {} during cleanup: {}", path, e);
}
}
}

#[test]
Expand Down Expand Up @@ -286,10 +283,7 @@ mod tests {

let result = run_guest_and_gdb(&cmd_file_path, &out_file_path, &cmd, checker);

// cleanup
let cleanup_result = cleanup(&out_file_path, &cmd_file_path);
assert!(cleanup_result.is_ok(), "{}", cleanup_result.unwrap_err());
// check if the test passed - done at the end to ensure cleanup is done
cleanup(&out_file_path, &cmd_file_path);
assert!(result.is_ok(), "{}", result.unwrap_err());
}

Expand Down Expand Up @@ -337,10 +331,7 @@ mod tests {
let checker = |contents: String| contents.contains("$2 = [1.20000005, 0, 0, 0]");
let result = run_guest_and_gdb(&cmd_file_path, &out_file_path, &cmd, checker);

// cleanup
let cleanup_result = cleanup(&out_file_path, &cmd_file_path);
assert!(cleanup_result.is_ok(), "{}", cleanup_result.unwrap_err());
// check if the test passed - done at the end to ensure cleanup is done
cleanup(&out_file_path, &cmd_file_path);
assert!(result.is_ok(), "{}", result.unwrap_err());
}
}
0