8000 Fix import torchao.prototype.low_bit_optim since torchao v0.11 by baptxste · Pull Request #38174 · huggingface/transformers · GitHub
[go: up one dir, main page]
Skip to content

Fix import torchao.prototype.low_bit_optim since torchao v0.11 #38174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 16, 2025
Merged

Fix import torchao.prototype.low_bit_optim since torchao v0.11 #38174

merged 4 commits into from
May 16, 2025

Conversation

baptxste
Copy link
Contributor
@baptxste baptxste commented May 16, 2025 •
edited
Loading

What does this PR do?

Update import path of AdamW4bit and AdamW8bit for torchao >= 0.11.0

@github-actions github-actions bot marked this pull request as draft May 16, 2025 09:24
@github-actions GitHub Actions
Copy link
Contributor

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@baptxste baptxste marked this pull request as ready for review May 16, 2025 09:27
Rocketknight1
Rocketknight1 approved these changes May 16, 2025
View reviewed changes
Copy link
Member
@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, LGTM! cc @SunMarc to confirm just in case

@Rocketknight1
Copy link
Member

@bot /style

@github-actions GitHub Actions
Copy link
Contributor

Style fixes have been applied. View the workflow run here.

@Rocketknight1 Rocketknight1 force-pushed the fix_torchao_import_v0_11 branch from 6687b84 to 4cff8a3 Compare May 16, 2025 12:50
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

SunMarc
SunMarc approved these changes May 16, 2025
View reviewed changes
Copy link
Member
@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@SunMarc SunMarc merged commit a438949 into huggingface:main May 16, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rocketknight1 Rocketknight1 Rocketknight1 approved these changes

@SunMarc SunMarc SunMarc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@baptxste @Rocketknight1 @HuggingFaceDocBuilderDev @SunMarc
0