8000 fix bug in distributed loss test by techkang · Pull Request #38166 · huggingface/transformers · GitHub
[go: up one dir, main page]
Skip to content

fix bug in distributed loss test #38166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 16, 2025
Merged

fix bug in distributed loss test #38166

merged 2 commits into from
May 16, 2025

Conversation

techkang
Copy link
Contributor

What does this PR do?

Fixes distributed loss test failed as mentioned in #35743 (comment)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@ydshieh @muellerzr @ @SunMarc

Tests on 2 GPUs:

base_loss: [8.4486, 9.0954, 7.8702, 7.9928, 7.2161, 8.3778, 8.0487, 6.1117, 7.283, 6.4819]
broken_loss: [8.4486, 9.3632, 7.6003, 7.4984, 6.6267, 7.4892, 7.9702, 5.6609, 6.8272, 6.3275]
fixed_loss: [8.4486, 9.0954, 7.8702, 7.9928, 7.2161, 8.3778, 8.0487, 6.1117, 7.283, 6.4819]

Tests on 8 GPUs:

base_loss: [9.1648, 8.8716, 7.6154, 7.4581, 6.6029, 6.2143, 5.2902, 5.4008, 5.253, 4.9834]
broken_loss: [9.387, 8.7627, 7.7227, 9.42, 7.2081, 5.9345, 5.0765, 6.0079, 4.9359, 5.4696]
fixed_loss: [9.1648, 8.8716, 7.6154, 7.4581, 6.6029, 6.2143, 5.2902, 5.4008, 5.253, 4.9834]

Others

I accidentally closed #36987. So I add the doc fix in this PR.

@github-actions GitHub Actions
Copy link
Contributor

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@github-actions github-actions bot marked this pull request as draft May 16, 2025 03:06
@techkang techkang marked this pull request as ready for review May 16, 2025 03:07
@ydshieh ydshieh requested a review from SunMarc May 16, 2025 06:47
SunMarc
SunMarc approved these changes May 16, 2025
View reviewed changes
Copy link
Member
@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@SunMarc SunMarc enabled auto-merge (squash) May 16, 2025 16:08
@SunMarc SunMarc merged commit ea29f61 into huggingface:main May 16, 2025
14 checks passed
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunMarc SunMarc SunMarc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@techkang @HuggingFaceDocBuilderDev @SunMarc
0