8000 [omni modality] support composite processor config by zucchini-nlp · Pull Request #38142 · huggingface/transformers · GitHub
[go: up one dir, main page]
Skip to content

[omni modality] support composite processor config #38142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[omni modality] support composite processor config #38142

wants to merge 6 commits into from

Conversation

zucchini-nlp
Copy link
Member
@zucchini-nlp zucchini-nlp commented May 15, 2025 •
edited
Loading

What does this PR do?

Experimental PR for now.

The issue is that we have always been saving audio and image processors under the same config name (preprocessor_config.json) which was totally fine until the recent release of omni models. Now if we try to save the omni-model processor, only the last attribute's config is saved and it overwrite all previous configs with the same naming

So inspired by how Qwen-Omni team merged two configs into one big preprocessor_config.json, we can save all modality configs as part of the processor similar to what we have for composite model configs.

@github-actions github-actions bot marked this pull request as draft May 15, 2025 08:38
@github-actions GitHub Actions
Copy link
Contributor

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@zucchini-nlp zucchini-nlp mentioned this pull request May 15, 2025
Closed
@zucchini-nlp
Copy link
Member Author

Keeping this one open. After internal discussions, we decided to save all configs in processor_config.json. Though the PR is still not ready for review, I will work on it with a slightly lower priority. Above mentioned issue for Omni models will be fixed by refactoring Feature Extractors

@github-actions GitHub Actions
83CF
Copy link
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: auto

@zucchini-nlp zucchini-nlp marked this pull request as ready for review July 25, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zucchini-nlp @HuggingFaceDocBuilderDev
0