8000 [FIX] Save speed metrics to logs by pavelgein · Pull Request #38136 · huggingface/transformers · GitHub
[go: up one dir, main page]
Skip to content

[FIX] Save speed metrics to logs #38136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2025
Merged

[FIX] Save speed metrics to logs #38136

merged 1 commit into from
May 15, 2025

Conversation

pavelgein
Copy link
Contributor

Previously, we calculated speed metrics and did not do anything with the result.

What does this PR do?

Save speed metrics to logs.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@pavelgein
[FIX] Save speed metrics to logs
fadb808 
Previously, we calculated speed metrics and did not do anything with the result.
@github-actions github-actions bot marked this pull request as draft May 15, 2025 04:38
@github-actions GitHub Actions
Copy link
Contributor

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@pavelgein pavelgein marked this pull request as ready for review May 15, 2025 04:44
@pavelgein pavelgein mentioned this pull request May 15, 2025
Closed
4 tasks
SunMarc
SunMarc approved these changes May 15, 2025
View reviewed changes
Copy link
Member
@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! Can you share the logs that you get just to check if this is working ?

@pavelgein
Copy link
Contributor Author

Thanks ! Can you share the logs that you get just to check if this is working ?

Unfortunately, I don't have console logs right now, but can show plots from ClearML interface
image

@pavelgein
Copy link
Contributor Author

Got console logs,

{'loss': 16.8527, 'grad_norm': 443.156198877649, 'learning_rate': 0.0, 'epoch': 0.33, 'num_input_tokens_seen': 16, 'train_runtime': 12.9532, 'train_tokens_per_second': 1.235}

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@SunMarc
Copy link
Member
SunMarc commented May 15, 2025

Awesome thanks !

@SunMarc SunMarc merged commit 0f77ca7 into huggingface:main May 15, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunMarc SunMarc SunMarc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pavelgein @HuggingFaceDocBuilderDev @SunMarc
0