10000 Fix auto batch size finder test by ivarflakstad · Pull Request #38125 · huggingface/transformers · GitHub
[go: up one dir, main page]

Skip to content

Fix auto batch size finder test #38125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025
Merged

Conversation

ivarflakstad
Copy link
Member

--auto_find_batch_size 0 has to be the last test argument because later the test does testargs[-1] = "1" :)

@ivarflakstad ivarflakstad requested a review from ydshieh May 14, 2025 11:59
Copy link
Contributor

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@github-actions github-actions bot marked this pull request as draft May 14, 2025 11:59
@ivarflakstad ivarflakstad marked this pull request as ready for review May 14, 2025 11:59
@ivarflakstad ivarflakstad enabled auto-merge (squash) May 14, 2025 12:08
@ivarflakstad ivarflakstad merged commit 1b00966 into main May 14, 2025
14 checks passed
@ivarflakstad ivarflakstad deleted the fix-auto-batch-size-finder-test branch May 14, 2025 12:12
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request May 14, 2025
Ensure --auto_find_batch_size is the last test arg so indexing is correct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0