8000 fix `check_bad commit.py` gives wrong results by ydshieh · Pull Request #38107 · huggingface/transformers · GitHub
[go: up one dir, main page]
Skip to content

fix check_bad commit.py gives wrong results #38107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2025
Merged

fix check_bad commit.py gives wrong results #38107

merged 1 commit into from
May 13, 2025

Conversation

ydshieh
Copy link
Collaborator
@ydshieh ydshieh commented May 13, 2025

What does this PR do?

During bisecting, it uses

elif f"{target_test} FAILED" in result.stdout:

to determine a commit fails a test or not.

However, since #35912, the output is kind altered with live log call, and the results are wrong (it think every commit passes).

This PR fixes the issue by checking

elif f"FAILED {target_test}" in result.stdout:

(at short test summary info)

current output running on main

tests/models/instructblipvideo/test_modeling_instructblipvideo.py::InstructBlipVideoModelIntegrationTest::test_expansion_in_processing
-------------------------------- live log call ---------------------------------
WARNING transformers.video_processing_utils:logging.py:328 You have video processor config saved in preprocessor.json file which is deprecated. Video processor configs should be saved in their own video_preprocessor.json file. You can rename the file or load and save the processor back which renames it automatically. Loading from preprocessor.json will be removed in v5.0.
FAILED

@github-actions github-actions bot marked this pull request as draft May 13, 2025 14:42
@github-actions GitHub Actions
< 8000 div class=" timeline-comment-group js-minimizable-comment-group js-targetable-element TimelineItem-body my-0 " id="issuecomment-2876816206">
Copy link
Contributor

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@ydshieh ydshieh marked this pull request as ready for review May 13, 2025 14:42
@ydshieh ydshieh force-pushed the check_bad_commit branch from e5731e5 to 7ce3603 Compare May 13, 2025 14:45
zucchini-nlp
zucchini-nlp approved these changes May 13, 2025
View reviewed changes
Copy link
Member
@zucchini-nlp zucchini-nlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ydshieh ydshieh merged commit 582d5e0 into main May 13, 2025
11 checks passed
@ydshieh ydshieh deleted the check_bad_commit branch May 13, 2025 14:58
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request May 14, 2025
@ydshieh @zucchini-nlp
fix check_bad commit.py gives wrong results (huggingface#38107)
9f481c5 
fix

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zucchini-nlp zucchini-nlp zucchini-nlp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ydshieh @HuggingFaceDocBuilderDev @zucchini-nlp
0