8000 Fix OneFormer integration test by qubvel · Pull Request #38016 · huggingface/transformers · GitHub
[go: up one dir, main page]

Skip to content

Fix OneFormer integration test #38016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 12, 2025
Merged

Conversation

qubvel
Copy link
Member
@qubvel qubvel commented May 8, 2025

What does this PR do?

Fix OneFormer integration test

@qubvel qubvel requested a review from ydshieh May 8, 2025 11:22
@qubvel qubvel marked this pull request as ready for review May 8, 2025 11:22
@qubvel
Copy link
Member Author
qubvel commented May 8, 2025

run-slow: oneformer

@qubvel qubvel removed the request for review from ydshieh May 8, 2025 11:22
Copy link
Contributor
github-actions bot commented May 8, 2025

This comment contains run-slow, running the specified jobs: This comment contains run-slow, running the specified jobs:

models: ['models/oneformer']
quantizations: [] ...

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@qubvel qubvel requested a review from ydshieh May 8, 2025 14:44
@qubvel qubvel enabled auto-merge (squash) May 8, 2025 14:45
Comment on lines -576 to +566
expected_slice = [[[3.1848, 4.2141, 4.1993], [2.9000, 3.5721, 3.6603], [2.5358, 3.0883, 3.6168]]]
expected_slice = [[3.1848, 4.2141, 4.1993], [2.9000, 3.5721, 3.6603], [2.5358, 3.0883, 3.6168]]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is an actual change, the rest is small refactoring

@qubvel
Copy link
Member Author
qubvel commented May 8, 2025

@qubvel
Copy link
Member Author
qubvel commented May 9, 2025

cc @ydshieh when you have bandwidth

Copy link
Collaborator
@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, especially of using assert_close.

@qubvel qubvel merged commit 4220039 into huggingface:main May 12, 2025
14 checks passed
@ydshieh
Copy link
Collaborator
ydshieh commented May 12, 2025

wow, you merged after 1 nano second I approved 😮

@qubvel
Copy link
Member Author
qubvel commented May 12, 2025

@ydshieh auto-merge magic 🪄

zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0