8000 enable d_fine finetuning properly by SangbumChoi · Pull Request #37962 · huggingface/transformers · GitHub
[go: up one dir, main page]
Skip to content

enable d_fine finetuning properly #37962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 14, 2025
Merged

enable d_fine finetuning properly #37962

merged 2 commits into from
May 14, 2025

Conversation

SangbumChoi
Copy link
Contributor
@SangbumChoi SangbumChoi commented May 5, 2025 •
edited
Loading

What does this PR do?

@qubvel as you suggested I have changed with very minimal code. Also seperated PR!

#37952

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@github-actions github-actions bot marked this pull request as draft May 5, 2025 13:56
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented May 5, 2025

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@SangbumChoi SangbumChoi marked this pull request as ready for review May 5, 2025 13:56
@qubvel qubvel requested review from qubvel and removed request for Rocketknight1 and ArthurZucker May 5, 2025 18:01
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@SangbumChoi
Copy link
Contributor Author

@qubvel soft ping :)

qubvel
qubvel approved these changes May 14, 2025
View reviewed changes
Copy link
Member
@qubvel qubvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@qubvel qubvel merged commit aa27fa7 into huggingface:main May 14, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qubvel qubvel qubvel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SangbumChoi @HuggingFaceDocBuilderDev @qubvel
0