8000 [MEGA] nit size test by ArthurZucker · Pull Request #23028 · huggingface/transformers · GitHub
[go: up one dir, main page]

Skip to content

[MEGA] nit size test #23028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 27, 2023

Conversation

ArthurZucker
Copy link
Collaborator

What does this PR do?

Adresses #23025, the input_shape should be tested, not input ids because it might be None.

@ArthurZucker ArthurZucker force-pushed the ArthurZucker/issue23025 branch from 859f806 to d31cf72 Compare April 27, 2023 13:43
@ArthurZucker ArthurZucker requested a review from sgugger April 27, 2023 13:52
Copy link
Collaborator
@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@HuggingFaceDocBuilderDev
Copy link
HuggingFaceDocBuilderDev commented Apr 27, 2023

The documentation is not available anymore as the PR was closed or merged.

@ArthurZucker ArthurZucker merged commit 1933231 into huggingface:main Apr 27, 2023
gojiteji pushed a commit to gojiteji/transformers that referenced this pull request Jun 5, 2023
* add fast not use warning

* properly check sequence_length vs chunk_size

* fixup
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
* add fast not use warning

* properly check sequence_length vs chunk_size

* fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0