Fix flashinfer plan call to use positional arguments for #3165 #3166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldk
reviewed
Apr 17, 2025
Comment on lines
+87
to
+94
| cu_seqlens, | ||
| indptr, | ||
| block_tables, | ||
| last_page_len, | ||
| num_heads, | ||
| num_kv_heads, | ||
| head_size, | ||
| page_size, |
There was a problem hiding this comment.
I don't think moving away from kwargs is the right solution. The error show exactly why using kwargs is good - it catches changes to arguments. We should update to the latest flashinfer, see: https://github.com/huggingface/text-generation-inference/pull/3164/files
But a lot of the test outputs change after upgrading, I haven't had the time yet to go through them and see if they are all minor fluctuations or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This changes the call to BatchPrefillWithPagedKVCacheWrapper.plan to use positional arguments instead of key value arguments. Not sure why python is acting like this
Fixes #3165
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@Narsil @danieldk - please review