FIX: Package checks for torchao, EETQ #2320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Torchao
Under some unknown circumstances, it can happen that even though
importlib.util.find_spec("torchao") is not None,
importlib_metadata.version("torchao") still fails. This error is now
caught. This error was noticed in the diffusers CI.
EETQ
This is basically a revert of huggingface#2226. That PR had to add a check to the
EETQ import as EETQ was broken for some time with latest
transformers (see NetEase-FuXi/EETQ#34 for
context) but that has been fixed.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
The one failing CI run is independent of this PR and fixed via #2314. |
Guy-Bilitski
pushed a commit
to Guy-Bilitski/peft
that referenced
this pull request
May 13, 2025
Torchao
Under some unknown circumstances, it can happen that even though
importlib.util.find_spec("torchao") is not None,
importlib_metadata.version("torchao") still fails. This error is now
caught. This error was noticed in the diffusers CI.
EETQ
This is basically a revert of huggingface#2226. That PR had to add a check to the
EETQ import as EETQ was broken for some time with latest
transformers (see NetEase-FuXi/EETQ#34 for
context) but that has been fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Torchao
Under some unknown circumstances, it can happen that even though
importlib.util.find_spec("torchao") is not None,importlib_metadata.version("torchao")still fails. This error is now caught, same as in diffusers. The error was noticed in the diffusers CI.EETQ
This is basically a revert of #2226. That PR had to add a check to the EETQ import as EETQ was broken for some time with latest transformers (see NetEase-FuXi/EETQ#34 for context) but that has been fixed.