8000 MAINT apply sorting of imports by bluenote10 · Pull Request #2279 · huggingface/peft · GitHub
[go: up one dir, main page]

Skip to content

MAINT apply sorting of imports #2279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

bluenote10
Copy link
Contributor

As discussed in #2265, this PR removes the temporarily introduced # noqa: I001, fixing the sorting of these imports.

@bluenote10 bluenote10 changed the title ENH apply sorting of imports MAINT apply sorting of imports Dec 13, 2024
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member
@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing the rule for sorting imports, LGTM. Failing CI is unrelated.

@BenjaminBossan BenjaminBossan merged commit cf0dfe5 into huggingface:main Dec 13, 2024
13 of 14 checks passed
Guy-Bilitski pushed a commit to Guy-Bilitski/peft that referenced this pull request May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0