8000 [Type Hint] VAE models by daspartho · Pull Request #365 · huggingface/diffusers · GitHub
[go: up one dir, main page]
Skip to content

[Type Hint] VAE models #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 5, 2022
Merged

[Type Hint] VAE models #365

merged 4 commits into from
Sep 5, 2022

Conversation

daspartho
Copy link
Contributor

Based on 8 of issue #287

@anton-l could you check it?
Thanks :)

anton-l
anton-l approved these changes Sep 5, 2022
View reviewed changes
Copy link
Member
@anton-l anton-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this one @daspartho! 😄

anton-l
anton-l approved these changes Sep 5, 2022
View reviewed changes
@HuggingFaceDocBuilderDev
Copy link
HuggingFaceDocBuilderDev commented Sep 5, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@daspartho
Copy link
Contributor Author

@anton-l Made the changes as per suggestion :)

@anton-l anton-l merged commit f085d2f into huggingface:main Sep 5, 2022
@daspartho daspartho deleted the type_hint_models_vae branch September 5, 2022 17:10
natolambert pushed a commit that referenced this pull request Sep 7, 2022
@daspartho @anton-l @natolambert
[Type Hint] VAE models (#365)
81AB
c37a5ed 
* [Type Hint] VAE models

* Update src/diffusers/models/vae.py

* apply suggestions from code review

Co-authored-by: Anton Lozhkov <aglozhkov@gmail.com>
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
@daspartho @anton-l
[Type Hint] VAE models (huggingface#365)
38fff9e 
* [Type Hint] VAE models

* Update src/diffusers/models/vae.py

* apply suggestions from code review

Co-authored-by: Anton Lozhkov <aglozhkov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-l anton-l anton-l approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daspartho @HuggingFaceDocBuilderDev @anton-l
0