[Type hint] PNDM schedulers #335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
| num_train_timesteps: int = 1000, | ||
| beta_start: float = 0.0001, | ||
| beta_end: float = 0.02, | ||
| beta_schedule: Optional[str] = "linear", |
There was a problem hiding this comment.
Suggested change
| beta_schedule: Optional[str] = "linear", | |
| beta_schedule: str = "linear", |
There was a problem hiding this comment.
beta_schedule has to be string I think :-)
| beta_start: float = 0.0001, | ||
| beta_end: float = 0.02, | ||
| beta_schedule: Optional[str] = "linear", | ||
| tensor_format: Optional[str] = "pt", |
There was a problem hiding this comment.
Suggested change
| tensor_format: Optional[str] = "pt", | |
| tensor_format: str = "pt", |
There was a problem hiding this comment.
Think the tensor_format cannot be None
| @@ -97,7 +97,7 @@ def __init__( | |||
| self.tensor_format = tensor_format | |||
| self.set_format(tensor_format=tensor_format) | |||
|
|
|||
| def set_timesteps(self, num_inference_steps, offset=0): | |||
| def set_timesteps(self, num_inference_steps: int, offset=0): | |||
There was a problem hiding this comment.
Suggested change
| def set_timesteps(self, num_inference_steps: int, offset=0): | |
| def set_timesteps(self, num_inference_steps: int, offset: int = 0) -> torch.FloatTensor: |
| original_samples: Union[torch.FloatTensor, np.ndarray], | ||
| noise: Union[torch.FloatTensor, np.ndarray], | ||
| timesteps: Union[torch.IntTensor, np.ndarray], | ||
| ): |
There was a problem hiding this comment.
Suggested change
| ): | |
| ) -> torch.Tensor: |
|
@patrickvonplaten made the necessary changes :) |
patrickvonplaten
approved these changes
Sep 4, 2022
natolambert
pushed a commit
that referenced
this pull request
Sep 7, 2022
* [Type hint] PNDM Schedulers * ran make style * updated timesteps type hint * apply suggestions from code review * ran make style * removed unused import
natolambert
pushed a commit
that referenced
this pull request
Sep 7, 2022
* [Type hint] PNDM Schedulers * ran make style * updated timesteps type hint * apply suggestions from code review * ran make style * removed unused import
patrickvonplaten
added a commit
that referenced
this pull request
Sep 8, 2022
* init schedulers docs * add some docstrings, fix sidebar formatting * add docstrings * [Type hint] PNDM schedulers (#335) * [Type hint] PNDM Schedulers * ran make style * updated timesteps type hint * apply suggestions from code review * ran make style * removed unused import * [Type hint] scheduling ddim (#343) * [Type hint] scheduling ddim * apply suggestions from code review apply suggestions to also return the return type Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com> Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com> * make style * update class docstrings * add docstrings * missed merge edit * add general docs page * modify headings for right sidebar Co-authored-by: Partho <parthodas6176@gmail.com> Co-authored-by: Santiago Víquez <santi.viquez@gmail.com> Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
PhaneeshB
pushed a commit
to nod-ai/diffusers
that referenced
this pull request
Mar 1, 2023
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
* [Type hint] PNDM Schedulers * ran make style * updated timesteps type hint * apply suggestions from code review * ran make style * removed unused import
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
* init schedulers docs * add some docstrings, fix sidebar formatting * add docstrings * [Type hint] PNDM schedulers (huggingface#335) * [Type hint] PNDM Schedulers * ran make style * updated timesteps type hint * apply suggestions from code review * ran make style * removed unused import * [Type hint] scheduling ddim (huggingface#343) * [Type hint] scheduling ddim * apply suggestions from code review apply suggestions to also return the return type Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com> Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com> * make style * update class docstrings * add docstrings * missed merge edit * add general docs page * modify headings for right sidebar Co-authored-by: Partho <parthodas6176@gmail.com> Co-authored-by: Santiago Víquez <santi.viquez@gmail.com> Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on 24, 25, and 26 of issue #287
@anton-l could you check it?
Thanks :)