fix: Kubernetes integration when using cgroups v2#327
Open
rossf7 wants to merge 2 commits intohubblo-org:devfrom
Open
fix: Kubernetes integration when using cgroups v2#327rossf7 wants to merge 2 commits intohubblo-org:devfrom
rossf7 wants to merge 2 commits intohubblo-org:devfrom
Conversation
rossf7
commented
Jun 8, 2023
| .strip_prefix("cri-containerd-") | ||
| .unwrap() | ||
| .to_string(); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
I needed to add this to be able to extract the container ID successfully.
benjaminlebigot
pushed a commit
to benjaminlebigot/scaphandre
that referenced
this pull request
Oct 24, 2023
PR corresponding to the changes: hubblo-org#327
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @bpetit,
I had a problem when testing with ubuntu:22.04 since it uses cgroups v2.
The paths are now relative so I needed to remove the
^from the regex.I also tested with ubuntu:20.04 to check compatibility with cgroups v1.